<!-- canonical: https://0xsimao.com/findings/codeup-hardcoded-values-present-codebase -->

# Hardcoded values present in the codebase

Low/Info · Three Sigma · DeFi game · 23rd October, 2024

Finding I-2 of the CODEUP security review.

- Report: /reports/codeup
- Source: https://cdn.sanity.io/files/qoqld077/staging/d9e57830a75b5165fd56e8b88037de7986a165ec.pdf

---

### Description

Hardcoded values should be avoided for better readability.

### Recommendation

The following instances were found: `(tokenAmount * 10) / 100` ([1](https://github.com/0x73696d616f/codeup-issues-external/blob/main/contracts/Codeup.sol#L173), [2](https://github.com/0x73696d616f/codeup-issues-external/blob/main/contracts/Codeup.sol#L230)), [Codeup::_syncTower()](https://github.com/0x73696d616f/codeup-issues-external/blob/main/contracts/Codeup.sol#L359-L362), [Codeup::_getUpgradePrice()](https://github.com/0x73696d616f/codeup-issues-external/blob/main/contracts/Codeup.sol#L380-L389), [Codeup::_getYield()](https://github.com/0x73696d616f/codeup-issues-external/blob/main/contracts/Codeup.sol#L400-L409)
