<!-- canonical: https://0xsimao.com/findings/districtone-meme-overfunded-eth-reverts -->

# Claiming will fail for Ole and D1MemeToken if the overfunded ETH reverts

Crit/High · Three Sigma · Social money games · 13th June, 2024

Finding 3S-D1-M01 of the DistrictOne security review.

- Protocol: https://districtone.io/
- Report: /reports/districtone
- Source: https://cdn.sanity.io/files/qoqld077/production/fd2142f1d189dd29db23dff49d4018d4da9c01d6.pdf

---

### Description

FairLauncher::claims() reverts if the ETH claimed from overfunded presales fails.
However, this means that Ole and D1MemeToken claiming will also revert, when this could be
prevented.

### Recommendation

Instead of reverting, the ETH could be sent to a protocol wallet and emit an event to refund
users later.
The likelihood of happening is low because the protocol expects its users to be EOAs or
multisig wallets, which don't have this problem.

### Status

Acknowledged

---

Related findings:

- [Hints on withdrawal may fail as the ICR changes between claiming collateral surplus and repaying debt](https://0xsimao.com/findings/beraborrow-i-hints-withdrawal-collateral-debt): Beraborrow Managed Dens
- [ETH withdrawals from EigenLayer always fail due to `OperatorDelegator`'s nonReentrant `receive()`](https://0xsimao.com/findings/renzo-eth-withdrawals-delegator-reentrant): Renzo
- [Some ETH transfers don't revert if they fail](https://0xsimao.com/findings/singularity-eth-transfers-don-revert): Singularity
