# UniswapV2Swapper uses block.timestamp for deadline [Out of scope] Crit/High · Three Sigma · Lending aggregator · 6th May, 2023 Finding 3S-FUJI-H03 of the Fuji Finance security review. - Report: /reports/fuji-finance - Source: https://cdn.sanity.io/files/qoqld077/staging/32181a28eac3175d15fb8924d249bb0d91ca350c.pdf --- ### Description Uniswap sets a deadline to limit arbitrage opportunities if the swap does not get included right away. If the swap specifies a deadline of block.timestamp, then the swap transaction can be included in any block. This means that the price can, by then, have changed significantly. ### Recommendation Send a deadline argument. ### Status Acknowledged with the following statement: The issue identified is acknowledged by the Fuji team. It is worth noting that the bundleInternal(...) currently has some indirect protection against slippage. However, Fuji will proceed to implement a deadline argument in the LiquidationManager.sol and BaseRouter.sol during Q3-2023 while working on general optimizations/improvements. --- Related findings: - [Swapping with deadline as block.timestamp and 0 minimum amount out is vulnerable to MEV](https://0xsimao.com/findings/clip-finance-i-swapping-deadline-timestamp-mev): Clip Finance Strategies - [`rewardData.releaseRate` is incorrectly calculated on `RewardsController::config()` when `block.timestamp > start` and `rewardData.lastConfig != rewardData.start`](https://0xsimao.com/findings/exactly-protocol-update-staking-contract-reward-release-rewards-timestamp): Exactly Protocol Update - Staking Contract - [API3 oracle timestamp can be set to future timestamp and block API3 Oracle usage to make code revert in underflow](https://0xsimao.com/findings/init-capital-ii-oracle-timestamp-revert-underflow): INIT Capital - [KeyringCoreV2Base::_createCredential() could use currentTime instead of block.timestamp on the creatBefore check](https://0xsimao.com/findings/keyring-ii-credential-current-timestamp-creat): Keyring Credentials