<!-- canonical: https://0xsimao.com/findings/glacier-reserve-constants-naming-conventions -->

# In GReservePool, use constants naming conventions

Low/Info · Three Sigma · Liquid staking · 12th July, 2023

Finding 3S-GLACIER-N15 of the Glacier security review.

- Protocol: https://www.glacier.io/
- Report: /reports/glacier
- Source: https://cdn.sanity.io/files/qoqld077/production/21bd3b6fa78c55968a6c9c7ea4fd49f34a8bd3d8.pdf

---

### Description

There are two constants in this contract (_maxStrategies and _defaultStrategyWeigth),
they should use the naming convention of being in capital letter the same way it is done in
the other contracts. They should be MAX_STRATEGIES and DEFAULT_STRATEGY_WEIGHT.

### Status

Currently being reviewed by the team.

---

Related findings:

- [`VaultPoolLib::reserve()` will store the `Pa` not attributed to user withdrawals incorrectly and leave in untracked once it expires again](https://0xsimao.com/findings/cork-protocol-attributed-withdrawals-untracked-expires): Cork Protocol
