<!-- canonical: https://0xsimao.com/findings/keyring-ii-missing-admin-change-events -->

# Missing admin change events

Low/Info · Three Sigma · Zero-knowledge compliance · 10th July, 2024

Finding 3S-Keyring-L02 of the Keyring Credentials security review.

- Protocol: https://www.keyring.network/
- Report: /reports/keyring-ii
- Source: https://cdn.sanity.io/files/qoqld077/production/75b68b74f4b0dc6fbcd94892d934547d8259b57a.pdf

---

### Description

When setting the admin in KeyringCoreV2Base::setAdmin() and the constructor an event
should be emitted.

### Recommendation

Emit events on all relevant state variable changes.

### Status

Addressed in [#ffe8b11](https://github.com/Keyring-Network/core-v2/commit/ffe8b11b3c8b1eaadb1713eb19e80872a9d1c630).

---

Related findings:

- [Important events are missing](https://0xsimao.com/findings/metazero-i-important-events-missing): MetaZero Omnichain NFTs
- [Missing some events](https://0xsimao.com/findings/metazero-ii-missing-events): MetaZero Staking
- [Missing key events when requesting withdrawals that could be important for the allocator bot](https://0xsimao.com/findings/yieldoor-iii-requesting-withdrawals-allocator-bot): Yieldoor LoopedVault Update
