<!-- canonical: https://0xsimao.com/findings/maple-finance-iii-documentation-pending-accept-implemented -->

# Missing documentation for MapleLoan, SetPendingLender and AcceptLender being implemented on MapleLoan but not on LoanManager.

Low/Info · Three Sigma · Institutional lending · 10th April, 2024

Finding 3S-MAPLE-N12 of the Maple Finance security review.

- Protocol: https://maple.finance/
- Report: /reports/maple-finance-iii-2024
- Source: https://cdn.sanity.io/files/qoqld077/production/36dbe5ca76da3d2392bcee581548067705b8bd36.pdf

---

### Description

Fixed and Open term loans implement SetPendingLender and AcceptLender; however, the
corresponding LoanManagers don't. This is a design choice to allow a future upgrade of
LoanManager without the necessity of upgrading MapleLoan.

### Status

Addressed in the following PR:
https://github.com/maple-labs/open-term-loan-manager-private/pull/56

---

Related findings:

- [Issue #497 'Add parameter to lender accept bid for MaxMarketFee' from previous audit is still present](https://0xsimao.com/findings/teller-finance-497-bid-fee-audit): Teller Finance
- [Drained lender due to `LenderCommitmentGroup_Smart::acceptFundsForAcceptBid()` `_collateralAmount` by `STANDARD_EXPANSION_FACTOR` multiplication](https://0xsimao.com/findings/teller-finance-bid-collateral-factor-multiplication): Teller Finance
- [Incorrect selector in `FlashRolloverLoan_G5::_acceptCommitment()` does not match `SmartCommitmentForwarder::acceptCommitmentWithRecipient()`](https://0xsimao.com/findings/teller-finance-rollover-match-forwarder-recipient): Teller Finance
- [`FlashRolloverLoan_G5` will fail for `LenderCommitmentGroup_Smart` due to `CollateralManager` pulling collateral from `FlashRolloverLoan_G5`](https://0xsimao.com/findings/teller-finance-flash-rollover-collateral-pulling): Teller Finance
