<!-- canonical: https://0xsimao.com/findings/maple-finance-iv-sky-cache-misses-underscores -->

# MapleSkyStrategy does not always cache the psm and misses underscores

Low/Info · Three Sigma · Institutional lending · 26th November, 2024

Finding 3S-Maple-N01 of the Maple Cash Strategies security review.

- Protocol: https://maple.finance/
- Report: /reports/maple-finance-iv
- Source: https://cdn.sanity.io/files/qoqld077/staging/a68d604be9eca467b1f656c2ca775e1cebc2a468.pdf

---

### Description

MapleSkyStrategy::_gemForUsds() and MapleSkyStrategy::_usdsForGem() do not
cache the psm nor add trailing underscores to tout and to18ConversionFactor.

### Recommendation

Implement the fixes to ensure gas savings and correct formats.

### Status

Addressed in [#c5a61a6](https://github.com/maple-labs/maple-strategies/pull/37/commits/c5a61a62cbf9b6ab96e42c436f5f77401245d0db), [#2ff1e0f](https://github.com/maple-labs/maple-strategies/pull/37/commits/2ff1e0fffb76da674ef26562904f650fc8442fc6).
