<!-- canonical: https://0xsimao.com/findings/maple-finance-iv-sky-psm-old-approval -->

# MapleSkyStrategy:: setPsm() should set the old Psm's approval to 0

Low/Info · Three Sigma · Institutional lending · 26th November, 2024

Finding 3S-Maple-N06 of the Maple Cash Strategies security review.

- Protocol: https://maple.finance/
- Report: /reports/maple-finance-iv
- Source: https://cdn.sanity.io/files/qoqld077/staging/a68d604be9eca467b1f656c2ca775e1cebc2a468.pdf

---

### Description

MapleSkyStrategy::setPsm() changes Psm, but does not set the old Psm approval to 0.

### Recommendation

Set the old Psm approval to 0 as it is no longer needed.

### Status

Addressed in [#6c9f85d](https://github.com/maple-labs/maple-strategies/pull/35/commits/6c9f85d5ba50ae512478301da9e5b4484d1d012d).

---

Related findings:

- [Factory update for maple loans can be performed with the old factory](https://0xsimao.com/findings/maple-finance-ii-factory-loans-performed-old): Maple Withdrawal Manager
- [`BaseTOFT.sol`: `retrieveFromStrategy` can be used to manipulate other user's positions due to absent approval check](https://0xsimao.com/findings/tapioca-dao-retrieve-manipulate-absent-approval): Tapioca DAO
- [Missing documentation for MapleLoan, SetPendingLender and AcceptLender being implemented on MapleLoan but not on LoanManager.](https://0xsimao.com/findings/maple-finance-iii-documentation-pending-accept-implemented): Maple Finance
- [Strategy main ticks are set according to the tick in slot0, leading to incorrect allocation and loss of funds](https://0xsimao.com/findings/yieldoor-main-according-slot0-allocation): Yieldoor
