<!-- canonical: https://0xsimao.com/findings/maple-finance-iv-slippage-control-withdrawing-arbitrage -->

# The basic strategy does not have slippage control when withdrawing which may lead to arbitrage

Low/Info · Three Sigma · Institutional lending · 26th November, 2024

Finding 3S-Maple-N04 of the Maple Cash Strategies security review.

- Protocol: https://maple.finance/
- Report: /reports/maple-finance-iv
- Source: https://cdn.sanity.io/files/qoqld077/staging/a68d604be9eca467b1f656c2ca775e1cebc2a468.pdf

---

### Description

MapleBasicStrategy::withdrawFromStrategy() does not send an upper limit on the
amount of shares minted, which means an unexpected loss may happen in case of slashing
before the withdrawal from the EIR4626 vault. Although many vaults do not have slashing
abilities (such as the one tested, SavingsUsds), some may do which can cause this issue.

### Recommendation

Consider adding slippage control on a case by case basis.

### Status

Acknowledged

---

Related findings:

- [`ManagedLeveragedVault::deposit()` slippage control on `collVaultShares` is not intuitive](https://0xsimao.com/findings/beraborrow-i-deposit-slippage-control-shares): Beraborrow Managed Dens
- [`ManagedLeveragedVault.sol::deposit()` is missing slippage control](https://0xsimao.com/findings/beraborrow-i-sol-deposit-slippage-control): Beraborrow Managed Dens
- [The StrategyExecutor can remain in a paused state if the owner renounces control while it's paused](https://0xsimao.com/findings/mitosis-remain-paused-renounces-control): Mitosis
- [BatchOut:executeBatchWithdrawFromStrategyWithSwap() gives unfairly different slippage depending on the chosen token](https://0xsimao.com/findings/clip-finance-i-withdraw-unfairly-slippage-depending): Clip Finance Strategies
