<!-- canonical: https://0xsimao.com/findings/metazero-i-hardcoded-variables-placed-constants -->

# Hardcoded variables should be placed as constants

Low/Info · Three Sigma · Omnichain RWA tokenisation · 27th January, 2024

Finding 3S-MetaZero-N04 of the MetaZero Omnichain NFTs security review.

- Protocol: https://metazero.gg/
- Report: /reports/metazero-i
- Source: https://cdn.sanity.io/files/qoqld077/production/1b1ab4ff365756fe1d86767f1e06744407570f5a.pdf

---

### Description

The [LzEndpoint](https://github.com/threesigmaxyz/metazero-issues-external/blob/master/src/ONFTV2-721C.sol#L48), a [minter](https://github.com/threesigmaxyz/metazero-issues-external/blob/master/src/ONFTV2-721C.sol#L55), the royalty [fee](https://github.com/threesigmaxyz/metazero-issues-external/blob/master/src/ONFTV2-721C.sol#L53) and the pay in zero flags [([1]](https://github.com/threesigmaxyz/metazero-issues-external/blob/master/src/ONFTV2-721C.sol#L108), [[2])](https://github.com/threesigmaxyz/metazero-issues-external/blob/master/src/ONFTV2-721C.sol#L152) are hardcoded
values, but should be placed as constants instead.

### Status

Acknowledged

---

Related findings:

- [Constants should be placed as constants and not hardcoded for better readability](https://0xsimao.com/findings/fuji-finance-constants-hardcoded-better-readability): Fuji Finance
- [Constants should not be hardcoded](https://0xsimao.com/findings/metazero-ii-constants-hardcoded): MetaZero Staking
