<!-- canonical: https://0xsimao.com/findings/mitosis-redeem-queue-resolved-count -->

# RedeemQueue::isResolved() resolvedCount always returns requestIds.length

Low/Info · Three Sigma · Cross-chain liquidity layer 1 · 25th June, 2024

Finding 3S-Mitosis-N06 of the Mitosis security review.

- Protocol: https://mitosis.org/
- Report: /reports/mitosis
- Source: https://cdn.sanity.io/files/qoqld077/production/b6b3bd7bb47407d99e76abb7c6dc615c1db5018e.pdf

---

### Description

resolvedCount in RedeemQueue::isResolved() always increments in the loop, regardless
of it being resolved_ or not.
The function is not exposed so it has no impact but could be a future issue.

### Recommendation

Only increment the count when it is resolved.

### Status

Addressed in [#9ec2322](https://github.com/mitosis-org/evm/pull/182/commits/9ec232291712dd734c4e9e54c10ff88e01682f6d).

---

Related findings:

- [OstiumOpenPnl::nextEpochValuesRequestCount stores the same information as nextEpochValues.length](https://0xsimao.com/findings/ostium-epoch-count-stores-information): Ostium
- [Queue MapleWithdrawalManager may revert due to honest removeShares() or manual redeem calls](https://0xsimao.com/findings/maple-finance-ii-queue-withdrawal-shares-redeem): Maple Withdrawal Manager
- [`SyrupBitcoinRouter::requestRedeem()` could also check if the asset picked to redeem has liquidity](https://0xsimao.com/findings/maple-finance-iii-syrup-bitcoin-redeem-picked): Maple Withdrawal Queue
