<!-- canonical: https://0xsimao.com/findings/orange-fee-event-constructors-brc20 -->

# Fee event is missing in the constructors of BRC20Factory and Vault

Low/Info · Three Sigma · Cross-chain bridge · 15th July, 2024

Finding 3S-OB-L05 of the Orange Bridge security review.

- Protocol: https://www.orangeweb3.com/
- Report: /reports/orange
- Source: https://cdn.sanity.io/files/qoqld077/production/686ad4e1d5035d69002f5f97e281e3c5a8b7ce00.pdf

---

### Description

The fee is set in the constructors of BRC20Factory and Vault, but the event is not emitted.

### Recommendation

Emit the FeeChanged event in the constructor of both contracts.

### Status

Addressed in [#edbf47e](https://github.com/orangecryptohq/orange-bridge-contract/commit/edbf47ea585b30ec4178ed8e9aec3ff7b3bb3ff6).

---

Related findings:

- [Missing priceFeedDisabled event in RedStonePriceFeedBase](https://0xsimao.com/findings/felix-price-disabled-red-stone): Felix Price Feeds
- [Missing event in VerifierHub::setVerifier()](https://0xsimao.com/findings/singularity-event-verifier-hub-set): Singularity
- [Incorrect `ERC4626ExceededMaxRedeem` event on `ManagedLeveragedVault.sol:: cancelWithdrawalIntent()`](https://0xsimao.com/findings/beraborrow-i-erc4626-exceeded-redeem-withdrawal): Beraborrow Managed Dens
- [Withdrawing after a slash event before the vault has ended will decrease `fixedSidestETHOnStartCapacity` by less than it should, so following users will withdraw more their initial deposit](https://0xsimao.com/findings/saffron-lido-vaults-slash-eth-withdraw-deposit): Saffron Lido Vaults
