<!-- canonical: https://0xsimao.com/findings/ostium-redundant-abi-decode-callback -->

# Redundant abi.decode() in OstiumTradesUpKeep::checkCallback()

Low/Info · Three Sigma · RWA perpetuals DEX · 19th February, 2024

Finding 3S-OS-N22 of the Ostium security review.

- Protocol: https://www.ostium.com/
- Report: /reports/ostium
- Source: https://cdn.sanity.io/files/qoqld077/production/a95b9c69e0f65d1d6b0e649f0d62a362358ca8ce.pdf

---

### Description

The second decoding on [L126](https://github.com/0xOstium/smart-contracts-threeSigma/blob/1b70cffbac621d39e321c159e45c048b703add92/src/OstiumTradesUpKeep.sol#L126) of the data parameter is identical to the first and does not
assign its result to any variable. This appears to be redundant and serves no discernible
purpose.

### Recommendation

Remove the duplicate abi.decode() call.

### Status

Addressed.
