<!-- canonical: https://0xsimao.com/findings/ostium-unused-price-keep-type -->

# Unused UPDATE_SL OstiumPriceUpKeep::OrderType

Low/Info · Three Sigma · RWA perpetuals DEX · 19th February, 2024

Finding 3S-OS-N14 of the Ostium security review.

- Protocol: https://www.ostium.com/
- Report: /reports/ostium
- Source: https://cdn.sanity.io/files/qoqld077/production/a95b9c69e0f65d1d6b0e649f0d62a362358ca8ce.pdf

---

### Description

Enum OrderType in IOstiumPriceUpKeep has a UPDATE_SL property which is never used.

### Recommendation

Remove this property if it is not used.

### Status

Addressed in [#ab4e1ae](https://github.com/0xOstium/smart-contracts-threeSigma/pull/58/commits/ab4e1aee3b52f006e41ef804055df3b84072d0b5).

---

Related findings:

- [reduceOnly limit order update does not take into account that a new amm may be selected, which may lead to loss of funds](https://0xsimao.com/findings/nftperp-i-reduce-account-amm-selected): Nftperp Exchange
- [Call _updateMarkPrice() whenever markPrice is changed](https://0xsimao.com/findings/nftperp-ii-mark-price-whenever-changed): Nftperp Matching Engine
