<!-- canonical: https://0xsimao.com/findings/ostium-unused-wrong-imports -->

# Unused and Wrong Imports

Low/Info · Three Sigma · RWA perpetuals DEX · 19th February, 2024

Finding 3S-OS-N07 of the Ostium security review.

- Protocol: https://www.ostium.com/
- Report: /reports/ostium
- Source: https://cdn.sanity.io/files/qoqld077/production/a95b9c69e0f65d1d6b0e649f0d62a362358ca8ce.pdf

---

## Description
Unused Imports
#### OstiumVault

```solidity
import './lib/ChainUtils.sol';
import '@openzeppelin/contracts/access/Ownable.sol';
import '@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol';
```

#### OstiumWhitelist
import '@openzeppelin/contracts/utils/Address.sol';
#### OstiumLockedDepositNft

```solidity
import '@openzeppelin/contracts/interfaces/IERC20Metadata.sol';
import '@openzeppelin/contracts/interfaces/IERC4626.sol';
```

#### OstiumPriceUpKeep

```solidity
import './lib/ChainUtils.sol';
import './interfaces/IOstiumTradingStorage.sol';
```

#### OstiumTradesUpKeep

```solidity
import 'src/interfaces/external/IChainlinkVerifierProxy.sol';
import 'src/interfaces/external/IChainlinkRewardManager.sol';
import 'src/interfaces/external/IChainlinkFeeManager.sol';
import
```

'@chainlink/contracts/src/v0.8/automation/interfaces/ILogAutomation.sol'; //
duplicate
#### OstiumTradingStorage
import './interfaces/IOstiumOpenPnl.sol';
Wrong imports
#### OstiumTradesUpKeep
import 'src/OstiumTrading.sol';
should be changed to
import 'src/interfaces/IOstiumPairInfos.sol';
Because it's only using theIOstiumPairInfos interface.
#### OstiumPairsStorage
import './interfaces/IOstiumTradingStorage.sol';
should be changed to
import './interfaces/IOstiumPairsStorage.sol';
Because it's only using theIOstiumPairsStorage interface.

### Status

Addressed in [#840e77e](https://github.com/0xOstium/smart-contracts-threeSigma/pull/58/commits/840e77ebed9b68eea317d1856700ec39b17707de).

---

Related findings:

- [Remove unused imports](https://0xsimao.com/findings/glacier-remove-unused-imports): Glacier