<!-- canonical: https://0xsimao.com/findings/singularity-parameter-uniswap-inputs-struct -->

# Unused noteCommitment parameter in UniswapRemoveLiquidityInputs struct

Low/Info · Three Sigma · Private DeFi access · 26th February, 2024

Finding 3S-SG-N08 of the Singularity security review.

- Protocol: https://www.thesingularity.network/
- Report: /reports/singularity
- Source: https://cdn.sanity.io/files/qoqld077/production/45b8aac56a2b8e3b557df4329ac9bf8220b64012.pdf

---

### Description

UniswapRemoveLiquidityInputs struct [in](https://github.com/portalgateme/darkpool-v1-zk-contracts-fork/blob/master/contracts/defi/uniswap/UniswapInputBuilder.sol#L42) UniswapInputBuilder has a parameter named
positionNoteCommitment which is not required.

### Recommendation

Remove the mentioned parameter.

### Status

Addressed in [#8b300f0](https://github.com/portalgateme/darkpool-v1-zk-contracts-fork/commit/8b300f07a28f2c073154c8de3e9e90ba64ef1934).

---

Related findings:

- [Remove unused imports](https://0xsimao.com/findings/glacier-remove-unused-imports): Glacier
- [`LenderCommitmentGroup_Smart` picks the wrong Uniswap price, allowing borrowing at a discount by swapping before withdrawing](https://0xsimao.com/findings/teller-finance-picks-uniswap-price-allowing): Teller Finance
- [removeLiquidity() in the amm calculates marginToRemove without updating the margin with the funding payment](https://0xsimao.com/findings/nftperp-i-calculates-margin-updating-payment): Nftperp Exchange
