<!-- canonical: https://0xsimao.com/findings/yieldoor-i-shadow-gauge-vesting-revert -->

# ShadowStrategyGauge::addVestingPosition() may revert if there is 0 liquidity to add

Low/Info · 0xSimao · Leveraged yield farming · 12th May 2025

Finding L-3 of the Yieldoor Gauges security review.

- Protocol: https://app.yieldoor.com/
- Report: /reports/yieldoor-i
- Source: https://github.com/0xSimao/audits/blob/main/0xSimao/2025-05-12-yieldoor-i.pdf

---

**Description:**

`ShadowStrategyGauge::_addVestingPosition(`) always tries to [mint](https://github.com/spacegliderrrr/yieldoor/blob/master/src/instances/ShadowStrategyGauge.sol#L580) liquidity, even if it is null. Thus, it may result in reverting, although the chance is extremely low and there isn't any relevant impact as there would be no liquidity to vest anyway (or it is very low).

**Recommended Mitigation:**

Skip adding liquidity if null.

---

Related findings:

- [Bad check in `Vesting.sol::_resetVestingPlans` will prevent users from adding additional liquidity in `SymmVesting.sol`](https://0xsimao.com/findings/symmio-staking-and-vesting-vesting-plans-additional-symm): Symmio, Staking and Vesting
- [Add a 0 address check on the pool when adding liquidity for greater verbosity](https://0xsimao.com/findings/nftperp-ii-add-adding-greater-verbosity): Nftperp Matching Engine
- [_addLiquidity() slippage is incorrectly set](https://0xsimao.com/findings/singularity-add-liquidity-slippage-incorrectly): Singularity
- [CurveAddLiquidityAssetManager::curveAddLiquidity() does not deal correctly with isLegacy = 0b10 and ETH](https://0xsimao.com/findings/singularity-curve-legacy-0b10-eth): Singularity
