Skip to content
Request an audit

‹ All findings

Scheduled withdrawals with unsupported tokens will be halted

Crit/HighClip Finance Strategies·Three Sigma · DeFi infrastructure · 10th November, 20233S-Clip Finance-H05

Description

A token might be supported at time A, letting users withdraw in BatchOut using this token. However, if the token is not supported anymore after withdrawals are scheduled, it won't be possible to call BatchOut:executeBatchWithdrawFromStrategyWithSwap(), as it will revert when trying to call router.withdrawFromStrategies(), here.

The workaround is supporting the token for a short period of time again to let users fulfill their withdrawals, but this could lead to other problems, given that it was previously deprecated.

Recommendation

Change the withdraw token to another supported token in executeBatchWithdrawFromStrategyWithSwap() if the token is no longer supported.

Status

Addressed in #8f3f6e4