Skip to content

Request an audit

‹ All findings

PHyperLPoolSwapInside::_swapWithCustomData() .approve() reverts for tokens that don't return a boolean

Low/InfoClip Finance Strategy Upgrade·by the Three Sigma team·DeFi infrastructure·15th March 20243S-Clip-L04

Report Page Source

Description

PHyperLPoolSwapInside::_swapWithCustomData() uses unsafe .approve() which does not return a bool on some tokens, reverting.

Recommendation

Use .forceApprove().

Status

Addressed in #0c8de23.

Found during Three Sigma’s team review · 0xSimao on the review team