Skip to content
Request an audit

‹ All findings

Claiming will fail for Ole and D1MemeToken if the overfunded ETH reverts

Crit/HighDistrictOne·Three Sigma · Social money games · 13th June, 20243S-D1-M01

Description

FairLauncher::claims() reverts if the ETH claimed from overfunded presales fails. However, this means that Ole and D1MemeToken claiming will also revert, when this could be prevented.

Recommendation

Instead of reverting, the ETH could be sent to a protocol wallet and emit an event to refund users later. The likelihood of happening is low because the protocol expects its users to be EOAs or multisig wallets, which don't have this problem.

Status

Acknowledged