Skip to content
Request an audit

‹ All findings

UniswapV2Swapper uses block.timestamp for deadline [Out of scope]

Crit/HighFuji Finance·Three Sigma · Lending aggregator · 6th May, 20233S-FUJI-H03

Description

Uniswap sets a deadline to limit arbitrage opportunities if the swap does not get included right away. If the swap specifies a deadline of block.timestamp, then the swap transaction can be included in any block.

This means that the price can, by then, have changed significantly.

Recommendation

Send a deadline argument.

Status

Acknowledged with the following statement: The issue identified is acknowledged by the Fuji team. It is worth noting that the bundleInternal(...) currently has some indirect protection against slippage.

However, Fuji will proceed to implement a deadline argument in the LiquidationManager.sol and BaseRouter.sol during Q3-2023 while working on general optimizations/improvements.