`PreDepositVault::maxDeposit/Mint()` are missing `maxDepositLimit` as per the ERC4626 spec

Low/InfoGAIB Pre-Vaults·Sherlock · AI compute financing · 28th March, 2025L-1

Summary

PreDepositVault has a maxDepositLimit which is not reflected in maxDeposit/Mint, breaking the ERC4626 spec.

Vulnerability Detail

From the spec,

MUST factor in both global and user-specific limits

Impact

Non EIP4626 compliance

Code Snippet

Tool Used

Manual Review

Recommendation

Override ERC4626::maxDeposit/mint() and implement the deposit limit there

PreDepositVault::maxDeposit/Mint() are missing maxDepositLimit as per the ERC4626 spec