Functions can be marked external when only called from other contracts

Low/InfoKeyring Credentials audit·Three Sigma·Zero-knowledge compliance·10th July, 20243S-Keyring-N05

Description

Functions that are never called internally should be marked external.

Recommendation

solidity

Set KeyringCoreV2Base::createCredential(), KeyringCoreV2Base::blacklistEntity(), KeyringCoreV2Base::unblacklistEntity(),

KeyringCoreV2Base::collectFees() to external.

Status

Addressed in #ffe8b11.

Disclosed by 0xSimao · Sherlock's 2025 Watson of the Year · 21 first places in 57 audit contests