Skip to content
Request an audit

‹ All findings

EIP712's _revertIfError should use all SignatureChecker.Error errors

Low/InfoM^0 Minter Gateway·Three Sigma · Stablecoin framework · 8th January, 2024Codebase3S-M^0-N16

Description

Function ERC712._revertIfError goes through the different error possibilities in SignatureChecker.Error and raises the right error accordingly. But some are missing: InvalidSignatureS and InvalidSignatureV.

Recommendation

Consider either using the missing ones for better error messaging instead of raising the more general InvalidSignature error, or removing the unused ones from the enum.

Status

Addressed in #7eef72d.