Skip to content
Request an audit

‹ All findings

MapleSkyStrategy:: _gemForUsds() suffers a rounding error up to approximately 1e12 Usds

Low/InfoMaple Cash Strategies·Three Sigma · Institutional lending · 26th November, 20243S-Maple-L01

ReportSource

Description

MapleSkyStrategy:: _gemForUsds() computes gemAmount_ = (usdsAmount_ * WAD) / (to18ConversionFactor * (WAD + tout));. As can be seen, to18ConversionFactor is 1e12 for a Usdc gem, which leads to a rounding up to 1e12 Usds.

Recommendation

As the rounding error corresponds to only 1e-6 USD and the operation is not called frequently, it's safe to ignore it.

Status

Acknowledged