Skip to content
Request an audit

‹ Findings database

Duplicated slippage check in SyrupUserActions

Low/InfoMaple Syrup audit·Three Sigma·Permissionless lending·23rd August, 20243S-SY-N02

Description

SyrupUserActions::_swap() checks the slippage at the end require(amountOut_ >= minAmountOut_, "SUA:S:INSUFFICIENT_AMOUNT_OUT");. When the asset out is USDC, it double checks the slippage in SyrupUserActions::_swapDaiForUsdc() as require(usdcOut_ >= minUsdcOut_, "SUA:SDU:INSUFFICIENT_AMOUNT_OUT");.

Recommendation

There is no need to check the slippage in SyrupUserActions::_swapDaiForUsdc().

Source

Disclosed by 0xSimao · Sherlock's 2025 Watson of the Year · 21 first places in 57 audit contests