Skip to content
Request an audit

‹ Findings database

BasicVault::_deposit() should always resolve with idle balance as the redeem queue may be disabled with requests pending

MediumMitosis audit·Three Sigma·Cross-chain liquidity layer 1·25th June, 20243S-Mitosis-M06

Description

BasicVault::_deposit() only calls BasicVault::_resolveWithIdleBalance() if the redeem queue is enabled; however, requests must be claimed if they were created before the redeem queue was disabled, so the idle balance must be reserved even when the redeem queue is disabled.

Recommendation

Always resolve with idle balance in the BasicVault::_deposit() function.

Status

Addressed in #edf8184.