Skip to content
Request an audit

‹ All findings

BasicVault::manualRedeem() and BasicVault::manualDeposit() are inconsistent

Low/InfoMitosis·Three Sigma · Cross-chain liquidity layer 1 · 25th June, 20243S-Mitosis-L03

ReportSource

Description

BasicVault::manualDeposit() does not pull assets from the msg.sender, but BasicVault::manualRedeem() burns shares from msg.sender, which is inconsistent. In fact, BasicVault::manualRedeem() is exactly the same as BasicVault::redeem(), the only difference being that the former is permissioned.

Recommendation

The purpose of BasicVault::manualRedeem() is unclear.

Status

Addressed in #07b77cf.