Skip to content
Request an audit

‹ All findings

BasicVault::getRedeemRequestOf() will revert as the redeem requests are filled with the wrong indexes

Low/InfoMitosis·Three Sigma · Cross-chain liquidity layer 1 · 25th June, 20243S-Mitosis-L04

ReportSource

Description

In BasicVault::getRedeemRequestOf(), redeemRequests is filled with the requests from the queue from the IndexByRequestor struct offset, which stores the last non resolved request. In the loop where redeemRequests is assigned, it does redeemRequests[i] = ..., but i starts at from, which may not be 0 and revert in this case.

Recommendation

Replace the code to redeemRequests[i - from] = ....

Status

Addressed in #99fee9a.