Skip to content
Request an audit

‹ All findings

getTriggerOrders() should be paginated or it may revert if enough orders are created

Low/InfoNftperp Exchange·Three Sigma · NFT perpetuals · 2nd January, 20243S-NFTPerp-L03

ReportSource

Description

There is no limit in the amount of triggerOrders, which means that the array may grow too large and make transactions revert due to the gas usage exceeding the block gas limit when calling getTriggerOrders().

Recommendation

Paginate the getter so users can fetch information safely.

Status

Acknowledged