Skip to content
Request an audit

‹ All findings

PriceFeed: First owner isn't set as valid keeper

Low/InfoNftperp Exchange·Three Sigma · NFT perpetuals · 2nd January, 20243S-NFTPerp-N03

Description

When changing contract owner, the keeper permission of the previous owner is revoked, and this permission is given to the new owner.

The issue is that during initialization, the initial owner isn't given this privilege, so they must then call setValidKeeper() to set themselves (or some other address) as a valid keeper.

Recommendation

Since the owner should have the power to directly perform keeper operations, and for consistency with the function transferOwnership(), it is recommended that this permission is given during ownership initialization, line 45.

Status

Acknowledged