Skip to content
Request an audit

‹ All findings

BRC20Factory and Vault do different checks when removing signers

Low/InfoOrange Bridge·Three Sigma · Cross-chain bridge · 15th July, 20243S-OB-N02

Description

BRC20Factory checks if the account is authorized and if its index stored in indexes[account] is smaller than the length of signers. Vault requires that the length of signers is bigger than 1 and the account is authorized.

Recommendation

The check that the index of the account is smaller than the length of signers is not required and can be removed. Also, decide if it makes sense to check if the length of the signers is bigger than 1 in the BRC20Factory or if this check is not required in both contracts.

Status

Acknowledged