Skip to content
Request an audit

‹ Findings database

StakingOperator::_setUnlockWindow() checks if the times are negative, which is impossible

Low/InfoSingularity audit·Three Sigma·Private DeFi access·26th February, 20243S-SG-N02

Description

In StakingOperator::_setUnlockWindow(), unlockWindowStart and unlockWindowDuration are uint256, so they can not be negative. However, the code checks for negative values, which is a waste of gas.

Recommendation

Replace both checks by equalities to 0.

Status

Addressed in #2e77492.

Source

Disclosed by 0xSimao · Sherlock's 2025 Watson of the Year · 21 first places in 57 audit contests