Skip to content
Request an audit

‹ All findings

Payback can be DoSed in the BorrowingVault, may be profitable for liquidators

MediumFuji Finance·Three Sigma · Lending aggregator · 6th May, 20233S-FUJI-M02

Description

The borrowing vault enables anyone to payback the debt of another user. Thus, attackers can frontrun a user payback transaction, payback 1 wei and stop users from paying back their debts. This would make sense for liquidators, who are incentivized to do this to liquidate users.

Recommendation

There are 2 alternatives:

  • Instead of reverting if the payback is bigger than the maximum, limit it to the maximum.
  • Only enable the user to payback its debt.

POC

https://github.com/threesigmaxyz/fuji-issues-external/blob/master/test/POC/POCPaybackDoSed.t.sol#L27

Status

Addressed here: Fujicracy/fuji-v2#642