Skip to content
Request an audit

‹ All findings

When transferring tokens, if the amount is 0, the transfer should be skipped

Low/InfoFuji Finance·Three Sigma · Lending aggregator · 6th May, 20233S-FUJI-N09

ReportSource

Description

Before each transfer call, if the amount is 0, it should be skipped. This is also true for SafeERC20.safeTransfer(...) and SafeERC20.safeTransferFrom(...).

Recommendation

An example would be

solidity
function _safeTransferETH(address receiver, uint256 amount) internal {
    if (amount == 0) return;
    (bool success,) = receiver.call{value: amount}(new bytes(0));
    if (!success) revert BaseRouter__safeTransferETH_transferFailed();
}

Status

Addressed here: Fujicracy/fuji-v2#652