Skip to content
Request an audit

‹ Findings database

In ConnextHandler, executeFailedWithUpdatedArgs(...), the whole tx is updated on storage if the try call succeeds

Low/InfoFuji Finance audit·Three Sigma·Lending aggregator·6th May, 20233S-FUJI-N08

Description

In the ConnextHandle, executeFailedWithUpdatedArgs(...), the failed tx executed field is set to true. Currently it is loaded in memory and then written to storage completely, which is unnecessary and adds significant gas overhead.

Recommendation

Change the code below try connextRouter.xBundle(actions, args) to _failedTxns[transferId][nonce].executed = true; to save on storage writes.

Status

Addressed here: Fujicracy/fuji-v2#657

Source

Disclosed by 0xSimao · Sherlock's 2025 Watson of the Year · 21 first places in 57 audit contests