Throughout code-base: missing address checks.
Description
Whenever addresses change in the code, it's important to be careful about the possibility of setting the wrong address. The following occurrences could be dangerous in this regard
- MapleProxyFactory, setGlobals(...)
- MapleGlobals, setMapleTreasury(...)- Fixed-term-loan-private, the constructor of MapleLoanFeeManager
Recommendation
Two options were suggested:
- use the setPending-accept pattern
- don't change addresses, given that the contracts are upgradeable
Status
Acknowledged by the team.