Skip to content
Request an audit

‹ Findings database

Usdc to Usds calculation in the Sky Strategy is slightly different than the Psm Usds Wrapper

Low/InfoMaple Cash Strategies audit·Three Sigma·Institutional lending·26th November, 20243S-Maple-N09

Description

In the psmWrapper, the Usds amount from the gem is calculated as usdsInWad = gemAmt18

  • gemAmt18 * psm.tout() / WAD; , but in the Sky Strategy it is calculated as (gemAmount_
  • to18ConversionFactor * (WAD + tout)) / WAD; .

Recommendation

Although the result is the same (including the rounding error), consider implementing the same exact formula.

Status

Addressed in #771a479.