Skip to content
Request an audit

‹ All findings

Notional difference in AmmRouter:removeLiquidty() may revert in certain cases

MediumNftperp Matching Engine·Three Sigma · NFT perpetuals · 29th January, 20243S-NFTPerp-M01

ReportSource

Description

AmmRouter:removeLiquidity() subtracts the long notional by the short notional if the size is bigger than 0 (contrary if size is smaller than 0), which may revert if the short notional is bigger than the long one.

Recommendation

Use the distance between the notionals.

Status

Addressed in #74bc3c3