Skip to content
Request an audit

‹ All findings

createAmmPairWith() in initialize() will revert if the pair already exists

MediumTrestle wTIA Bridge·by the Three Sigma team·Modular blockchain infrastructure·27th January 20243S-TR-M04

Report PageSource

Description

createAmmPairWith() in initialize() reverts if the pair exists, which means that the contract could be DoSed.

Recommendation

Check if the pair already exists and skip creating if it does. However, this would make addLiquidityETH() vulnerable to slippage, so introduce slippage control arguments.

Status

Protocol already deployed.

Found during Three Sigma’s team review · 0xSimao on the review team