Skip to content
Request an audit

‹ All findings

Casting from int256 to uint256 won't revert if the number is negative, possibly leading to issues

Crit/HighOstium·Three Sigma · RWA perpetuals DEX · 19th February, 20243S-OS-M11

ReportSource

Description

Some instances, namely in OstiumPairInfos::getPendingAccFundingFees(), cast int256 to uint256.

Recommendation

Avoid casting directly and use a wrapper library instead such as SafeCastUpgradeable.

Status

Addressed in #38b09ab.