Skip to content
Request an audit

‹ Findings database

Consider using forceApprove instead of safeApprove in OstiumTraidingCallbacks

Low/InfoOstium audit·Three Sigma·RWA perpetuals DEX·19th February, 20243S-OS-N23

Description

safeApprove should only be called when setting an initial allowance, because it reverts when a non-zero approval is changed to a non-zero approval.

Even though it's only called with either type(uint256).max or 0, using forceApprove is safer.

Status

Addressed in #55fde4e.

Source

Disclosed by 0xSimao · Sherlock's 2025 Watson of the Year · 21 first places in 57 audit contests