Skip to content
Request an audit

‹ All findings

Inconsistent Precision of Percentage Variables

Low/InfoOstium·Three Sigma · RWA perpetuals DEX · 19th February, 20243S-OS-N04

Description

Throughout the codebase, variables representing percentages maintain a precision of 2 decimal places. However, there are instances where this precision is not consistently applied:

  • The MAX_GAIN_P variable on L31 in OstiumTradingCallbacks.
  • The maxSl_P variable on L47 in OstiumTradingCallbacks.
  • The liqThresholdP variable in OstiumPairInfos.
  • The liqFeeP variable of the Fee struct in OstiumPairsStorage.

Recommendation

It is advisable to review the contracts and ensure that variables representing percentages consistently adhere to a precision of two decimal places.

Status

Acknowledged