Skip to content
Request an audit

‹ Findings database

OstiumTrading::canExecute() should also be checked in OstiumTradesUpKeep::checkCallback()

Low/InfoOstium audit·Three Sigma·RWA perpetuals DEX·19th February, 20243S-OS-N13

Description

Orders in OstiumTrading::executeAutomationOrder() will not execute if they are in the timeout period.

This same check should exist in OstiumTradesUpKeep::checkCallback() to ensure that non executable orders are added to tradesToTrigger.

Recommendation

Add the timeout check to OstiumTradesUpKeep::checkCallback().

Status

Addressed in #20d8cee.

Source

Disclosed by 0xSimao · Sherlock's 2025 Watson of the Year · 21 first places in 57 audit contests