Skip to content
Request an audit

‹ All findings

Amounts to distribute are added directly to tokenPerShare, skipping using rewardPerToken

MediumTrestle wTIA Bridge·by the Three Sigma team·Modular blockchain infrastructure·27th January 20243S-TR-M05

Report PageSource

Description

Rewards are emitted at a rate of rewardTokenPerBlock. However, when distributing, the received reward tokens are added directly to rewardPerToken, instead of being left in the contract and letting rewardTokenPerBlock distribute the amounts over time.

Recommendation

Don't add the amount to swap to amountToDistribute, but let the tokens in the contract so rewards can be emitted according to rewardTokenPerBlock.

In fact, the swap should be performed before calculating emittedRewards(), so it does not happen that the tokens to distribute are cropped due to not having enough balance and then due to the swap there is now balance.

Status

Addressed by disabling taxes.

Found during Three Sigma’s team review · 0xSimao on the review team