Skip to content
Request an audit

‹ All findings

state.cumulativeDepositsMultiplierX18 may become 0 or negative, leading to loss of funds

Crit/HighVertex·by the Three Sigma team·Hybrid orderbook DEX·3rd April 20243S-Vertex-H01

Report PageSource

Description

state.cumulativeDepositsMultiplierX18 may go below 0 if an account is socialized or in the worst case, 0, which will have greater impact.

The point of socializing a spot account is eliminating the borrowed amount from the short account and transferring it to the other depositors.

The problem is that the multiplier may become 0 or negative which is never handled. If the multiplier goes to 0, every deposit will revert and the user will lose its funds.

If it becomes negative, every deposit will be treated as a short instead and the user may be liquidated (deposits have no health check).

Recommendation

Don't let the multiplier become 0 or lower by reverting in this case.

Status

Addressed in #38bbe76.

Found during Three Sigma’s team review · 0xSimao on the review team