Skip to content
Request an audit

‹ All findings

Downcasting Leads to Silent Overflow

Low/InfoVertex·by the Three Sigma team·Hybrid orderbook DEX·3rd April 20243S-Vertex-L02

Report PageSource

Description

Variables of type int128 are being upcasted to int256 and then downcasted again in the burnLp function in PerpEngineLp.sol and SpotEngineLP.sol, leading to silent overflow.

Recommendation

Consider using a solution like OpenZeppelin's SafeCast Library.

Status

Acknowledged

Found during Three Sigma’s team review · 0xSimao on the review team