Skip to content
Request an audit

‹ All findings

RiskHelper::isoGroup() returns 0, regardless of the passed subaccount

Low/InfoVertex·by the Three Sigma team·Hybrid orderbook DEX·3rd April 20243S-Vertex-N03

Report PageSource

Description

RiskHelper::isoGroup() is called in various functions across the code such as

solidity
RiskHelper::canTrade(), SpotEngine::socializeSubaccount(), PerpEngine::socializeSubaccount(), ClearinghouseLiq::_assertLiquidationAmount(), ClearinghouseLiq::_assertCanLiquidateLiability(),

ClearinghouseLiq::_finalizeSubaccount(), and ClearinghouseLiq_settlePositivePerpPnl().

However, it always returns 0 regardless of its parameter subaccount.

Recommendation

Implement the functionality (currently commented out) or fully remove this function.

Status

Acknowledged

Found during Three Sigma’s team review · 0xSimao on the review team