Skip to content
Request an audit

‹ All findings

Any user may enforce the referral code of other new users

Low/InfoVertex·by the Three Sigma team·Hybrid orderbook DEX·3rd April 20243S-Vertex-L09

Report PageSource

Description

In Endpoint::depositCollateralWithReferral(), the referral is set to

solidity
DEFAULT_REFERRAL_CODE if it is a remote deposit (sender != address(bytes20(subaccount)). Thus, any user may maliciously set other subaccount

referral code to default. It's also possible to do this by submitting a slow mode transaction of type BurnLpAndTransfer.

Recommendation

The specific fix depends on how the referral code is supposed to be handled.

Status

Addressed in #38bbe76.

Found during Three Sigma’s team review · 0xSimao on the review team