Skip to content
Request an audit

‹ Findings database

updateGroupCollateral() should revert if the _pairIndex does not exist

Low/InfoOstium audit·Three Sigma·RWA perpetuals DEX·19th February, 20243S-OS-N17

Description

OstiumPairsStorage::updateGroupCollateral() does not check for the pair's index existence, which means that it would update group with index 0 incorrectly.

Recommendation

Add if (!isPairIndexListed[_pairIndex]) revert PairNotListed(_pairIndex); to the function.

Status

Addressed in #ee024b2.

Source

Disclosed by 0xSimao · Sherlock's 2025 Watson of the Year · 21 first places in 57 audit contests